"The X to end all X" normally takes a good thing and makes it better (The cake to end all cakes) or a bad thing to make it worse. (The headache to end all headaches)

But yesterday I realized that there's at least one expection: "The girlfriend to end all girlfriends" is based on a good thing but it sounds terrible.